Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added java.exe as alternate binary name for Java #409
No because now it searches first for 'java', and if it is found, sets it as the path, if not found, searches for the 'alternative' name 'java.exe'.
Unless you meant something else?
To be fair, I'd like a unix/mac user to test it as well. I couldn't get the JDK to install on my mac, so I've not yet been able to test it on a non-windows environment, but I ran a test against the function and it showed it checking for both 'java' and 'java.exe'.
Actually, while this doesn't break anything in other environments, a more full fix would be to also include 'java' in the binary_names variable so that that will be searched for by find_file. The reason is that for some reason while find_file() searches the JAVAHOME paths for BOTH filename and file_names, it only uses the 'which' command to search for file_names, but not filename.
This is easy to fix, and I will submit another commit and pull request unless there is a reason that it won't work that I am not aware of.