New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort lowest common hypernyms by Synset name #465

Merged
merged 1 commit into from Sep 19, 2013

Conversation

Projects
None yet
2 participants
@pquentin
Contributor

pquentin commented Aug 22, 2013

Proposal for sorting synsets in lowest_common_hypernyms: see issue #458

@pquentin

This comment has been minimized.

Show comment
Hide comment
@pquentin

pquentin Aug 26, 2013

Contributor

Is there anything else I need to do? This was "doctested" successfully on both Python 2.7 and Python 3.3.

Contributor

pquentin commented Aug 26, 2013

Is there anything else I need to do? This was "doctested" successfully on both Python 2.7 and Python 3.3.

@stevenbird

This comment has been minimized.

Show comment
Hide comment
@stevenbird

stevenbird Sep 19, 2013

Member

Sorry for the delay. I think this solution is a nice compromise (compared with using sets across the board, a major change).

Member

stevenbird commented Sep 19, 2013

Sorry for the delay. I think this solution is a nice compromise (compared with using sets across the board, a major change).

stevenbird added a commit that referenced this pull request Sep 19, 2013

Merge pull request #465 from pquentin/master
Sort lowest common hypernyms by Synset name

@stevenbird stevenbird merged commit d274e27 into nltk:master Sep 19, 2013

@pquentin pquentin deleted the pquentin:master branch Feb 14, 2014

kruskod pushed a commit to kruskod/nltk that referenced this pull request Jul 15, 2015

Merge pull request nltk#465 from pquentin/master
Sort lowest common hypernyms by Synset name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment