Always free proxy_auth

nmap · Aug 18, 2017 · 35e1425 · 35e1425
1 parent 19d62a8
commit 35e1425
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/ncat/ncat_connect.c b/ncat/ncat_connect.c
@@ -788,6 +788,8 @@ static int do_proxy_socks5(void)
             goto error;
     }
 
+    free(proxy_auth);
+
     zmem(&socks5msg2,sizeof(socks5msg2));
     socks5msg2.ver = SOCKS5_VERSION;
     socks5msg2.cmd = SOCKS_CONNECT;
@@ -876,8 +878,7 @@ static int do_proxy_socks5(void)
 
     return(sd);
 error:
-    if (proxy_auth != NULL)
-        free(proxy_auth);
+    free(proxy_auth);
     close(sd);
     return -1;