New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 OS detection engine does not obey --max-rtt-timeout #1007

Open
dmiller-nmap opened this Issue Sep 11, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@dmiller-nmap

dmiller-nmap commented Sep 11, 2017

As discussed in #995, FPEngine.cc contains similar calculations to those in timing.cc, but it is missing checks against o.maxRttTimeout(), potentially leading to longer scan times. We should add this simple check, look for other missing checks, and try to combine equivalent functions where possible.

@sakshi-bansal

This comment has been minimized.

Show comment
Hide comment
@sakshi-bansal

sakshi-bansal Nov 26, 2017

Hello,

I am new to nmap and would like to contribute. I have 'possibly' fixed this bug and here is the patch sakshi-bansal@3bdc024. Please assign this bug to me and review the patch.

sakshi-bansal commented Nov 26, 2017

Hello,

I am new to nmap and would like to contribute. I have 'possibly' fixed this bug and here is the patch sakshi-bansal@3bdc024. Please assign this bug to me and review the patch.

@HeyAEE

This comment has been minimized.

Show comment
Hide comment
@HeyAEE

HeyAEE Mar 14, 2018

I would like to help out on this issue.

HeyAEE commented Mar 14, 2018

I would like to help out on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment