New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make http-fetch prepend host:port directory to destination #1099

Closed
dmiller-nmap opened this Issue Jan 8, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@dmiller-nmap

dmiller-nmap commented Jan 8, 2018

http-fetch downloads files like wget, but although it takes a destination directory script-arg, it doesn't keep separate subdirectories for separate targets. We should automatically create a host:port directory below the destination and keep the files in there.

@aniketp

This comment has been minimized.

Show comment
Hide comment
@aniketp

aniketp Jan 8, 2018

@dmiller-nmap I'll work on it.

aniketp commented Jan 8, 2018

@dmiller-nmap I'll work on it.

aniketp added a commit to aniketp/nmap that referenced this issue Jan 8, 2018

Create host:port sub-directory to destination
This commit fixes nmap#1099 on creation of separate sub-directories for each target in the form of (host:port)

aniketp added a commit to aniketp/nmap that referenced this issue Jan 8, 2018

Create host:port sub-directory for destination
This commit fixes nmap#1099 on creation of separate sub-directories for each target in the form of (host:port)
@aniketp

This comment has been minimized.

Show comment
Hide comment
@aniketp

aniketp Jan 8, 2018

@dmiller-nmap Fixed in #1100 . Please have a look.

aniketp commented Jan 8, 2018

@dmiller-nmap Fixed in #1100 . Please have a look.

NK-Nikunj added a commit to NK-Nikunj/nmap that referenced this issue Jan 9, 2018

Added host:port sub-directory to destination
This commit attempts to fix the issue nmap#1099 wrt to creation of separate sub-directories for each target.
This commit will now enable the user to download to destination/target-name_or_ip/port:port_number.
@NK-Nikunj

This comment has been minimized.

Show comment
Hide comment
@NK-Nikunj

NK-Nikunj Jan 9, 2018

Hello @dmiller-nmap

I have been using nmap for quite some time(off-course for white hat purpose). I am new to open source community and would like to contribute.

NK-Nikunj commented Jan 9, 2018

Hello @dmiller-nmap

I have been using nmap for quite some time(off-course for white hat purpose). I am new to open source community and would like to contribute.

NK-Nikunj added a commit to NK-Nikunj/nmap that referenced this issue Jan 10, 2018

Update http-fetch.nse
This commit attempts to fix the issue nmap#1099 wrt to creation of separate sub-directories for each target.
This commit will now enable the user to download to destination/target-name_or_ip/port:port_number.

NK-Nikunj added a commit to NK-Nikunj/nmap that referenced this issue Jan 10, 2018

fix for issue nmap#1102
This commit attempts to fix the issue nmap#1099 wrt to creation of separate sub-directories for each target.
This commit will now enable the user to download to destination/target-name_or_ip/port-port_number.

@nmap-bot nmap-bot closed this in 098e327 Jan 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment