New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie name/value confusion in Set-Cookie header #1198

Closed
nnposter opened this Issue Apr 25, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@nnposter

nnposter commented Apr 25, 2018

Parser for Set-Cookie header (function parse_set_cookie in http.lua) is currently allowing theoretical cookie attributes named "name" or "value" to stomp over the parsed cookie name or value.

There is no easy way to avoid this potential collision without changing the cookie object structure but it is prudent to enforce that the cookie name and value take priority over these attributes.

(This issue is for record only; a fix is coming.)

@nnposter

This comment has been minimized.

Show comment
Hide comment
@nnposter

nnposter Apr 25, 2018

Resolved with r37235 (23d61f5)

nnposter commented Apr 25, 2018

Resolved with r37235 (23d61f5)

@nnposter nnposter closed this Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment