Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncat no resolves the desired endpoint in PROXY connections #1230

Closed
jaymzh opened this issue Jun 1, 2018 · 8 comments

Comments

@jaymzh
Copy link

commented Jun 1, 2018

I spent a while git-bisecting this and it comes down to this commit:

21b7e38

Before this commit, if you did:

./ncat/ncat --proxy-type http --proxy MYPROXY:8080 ENDPOINT

Then what was sent to MYPROXY was:

CONNECT [2611:1a:e10::4]:22 HTTP/1.0\r\n

Where 2611:1a:e10::4 is the IPv6 address of ENDPOINT.

After this commit, this is sent:

CONNECT ENDPOINT:22 HTTP/1.0\r\n

Which the proxy may not be able to resolve which causes a failed to resolve error, which then breaks being able to proxy.

@landgraf

This comment has been minimized.

Copy link

commented Jun 4, 2018

Can you verify please?
#1214

@jaymzh

This comment has been minimized.

Copy link
Author

commented Jun 4, 2018

I'll give that a shot today, but I'm referring to HTTP proxy, not socks4 proxy, and that commit looks specific to socks4.

@landgraf

This comment has been minimized.

Copy link

commented Jun 4, 2018

Yes, I see now. But the problem is pretty much the same. Will check if it can be fixed in same PR for http proxy as well

@jaymzh

This comment has been minimized.

Copy link
Author

commented Jun 4, 2018

Thanks. Ping me again when the PR is updated, and I'll happily test.

jaymzh added a commit to jaymzh/nmap that referenced this issue Jun 11, 2018
[ncat] Fix v6 connectivity
When you pass in a v6 literal (to work around nmap#1230), you run into the problem
that ncat adds an extra square-bracket breaking the syntax.
@nnposter

This comment has been minimized.

Copy link

commented Jan 22, 2019

Could you please take a look at #1439 and let me know if it would meet your needs?

@nnposter nnposter added the Ncat label Jan 22, 2019

@nnposter nnposter self-assigned this Jan 22, 2019

@jaymzh

This comment has been minimized.

Copy link
Author

commented Jan 22, 2019

commented on the PR, thanks!

@landgraf

This comment has been minimized.

Copy link

commented Jan 24, 2019

Hi @nnposter ,
#1439 looks good. Thanks!

@nnposter

This comment has been minimized.

Copy link

commented Feb 23, 2019

Ability to control DNS resolution implemented in r37586. Thank you for raising up the issue.

@nmap-bot nmap-bot closed this in dbed133 Feb 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.