Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npcap 0.992 regression: pcap_lib_version #1566

Closed
gpotter2 opened this issue Apr 21, 2019 · 2 comments
Closed

Npcap 0.992 regression: pcap_lib_version #1566

gpotter2 opened this issue Apr 21, 2019 · 2 comments

Comments

@gpotter2
Copy link

@gpotter2 gpotter2 commented Apr 21, 2019

Hi !

We use pcap_lib_version to detect which version the user is running (basically we used to parse for Npcap instead of Winpcap), as advised by the doc:

https://github.com/nmap/npcap/blob/a8982716bd2d7a080b43aeb97507a681f48dacee/docs/npcap-devguide.xml#L129-L145

However this behavior has changed:

  • with 0.992
>>> pcap_lib_version()
b'libpcap version 1.9.0 (packet.dll version 0.992)'
  • with 0.991
>>> pcap_lib_version()
b'Npcap version 0.991, based on libpcap version 1.8.1'

This breaks the detection. If this is expected, please update the doc accordingly :-)

@fyodor
Copy link
Member

@fyodor fyodor commented Apr 21, 2019

Thanks for the report, @gpotter2. A build system change caused this, but @bonsaiviking fixed it for the next version, which we hope to release this week.

@fyodor fyodor closed this as completed Apr 21, 2019
@gpotter2
Copy link
Author

@gpotter2 gpotter2 commented Apr 21, 2019

Thanks for the info !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants