Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPcap: C:\npcap-sdk-0.1\Include #1875

Open
david-delaune opened this issue Jan 1, 2020 · 2 comments
Open

NPcap: C:\npcap-sdk-0.1\Include #1875

david-delaune opened this issue Jan 1, 2020 · 2 comments
Labels

Comments

@david-delaune
Copy link

@david-delaune david-delaune commented Jan 1, 2020

Yeah,

Your team has hard-coded the npcap include paths. Please change them to use a relative path.

@dmiller-nmap

This comment has been minimized.

Copy link

@dmiller-nmap dmiller-nmap commented Jan 2, 2020

I agree this isn't the cleanest way. What I want is a single place where the path to the Npcap SDK can be configured, so that a user can easily copy one of the Examples to make a new project. I thought I might define a parameter on the msbuild command line and then reference that in the project files, but I couldn't figure out how to do that back when I updated the Examples directory. Do you know a good way to do that?

@dmiller-nmap dmiller-nmap added the Npcap label Jan 2, 2020
@david-delaune

This comment has been minimized.

Copy link
Author

@david-delaune david-delaune commented Jan 2, 2020

Do you know a good way to do that?

Yes, by the way the GNU makefiles look fine. However the Microsoft Visual Studio projects needs to be modified to use relative paths. You can take advantage of the common macros

Instead of using hard coded paths you can use $(SolutionDir)..\Include

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.