Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users seeing STATUS_CANCELLED from PacketReceivePacket() #1903

Open
guyharris opened this issue Jan 31, 2020 · 1 comment
Open

Users seeing STATUS_CANCELLED from PacketReceivePacket() #1903

guyharris opened this issue Jan 31, 2020 · 1 comment

Comments

@guyharris
Copy link

@guyharris guyharris commented Jan 31, 2020

That error has been reported in Wireshark bug 16329 and bug 16355.

It looks as if the most likely reason for that would be that NPF_Pause() is called before pcap_dispatch()/pcap_loop() without NPF_Restart() also having been called after NPF_Pause() but before the libpcap routine.

According to Pausing a Driver Stack; might that be occurring due to adding (or removing?) a binding? The second bug involves disconnecting from the Wi-Fi network, which might tweak bindings if, for example, a disconnected adapter doesn't have the Internet protocol stack bound to it but a connected adapter does.

Is this covered by the comment

/* TODO: Allow the read to continue if the filter module is
 * detached (NPF_StartUsingOpenInstance above returned false)
 * but we have packet data in the buffer that can still be
 * delivered. */

in NPF_Read()?

And should there be OpenPausing and OpenPaused states, so that the instance isn't marked as "closing" or "closed" if it's just being paused or finished being paused?

@dmiller-nmap

This comment has been minimized.

Copy link

@dmiller-nmap dmiller-nmap commented Feb 3, 2020

That sounds reasonable. I'll take a closer look at making these changes after the next release (this week, I hope), since I want this to be a solid bugfix release without new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.