Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed improvement for script afp-ls #2098

Closed
nnposter opened this issue Aug 10, 2020 · 1 comment
Closed

Speed improvement for script afp-ls #2098

nnposter opened this issue Aug 10, 2020 · 1 comment
Assignees

Comments

@nnposter
Copy link

@nnposter nnposter commented Aug 10, 2020

Script afp-ls spends an exorbitant amount of time on collecting file details because files on a volume are first enumerated but then individual file parameters, such as size, permissions, and modification time, are queried one request at a time. In the end, roughly 3*N+1 requests are sent for a volume with N files.

It appears possible to utilize the initial enumeration (which uses FPEnumerateExt2 at the protocol level) to receive all the necessary file details as well, so only one request is needed per volume, even though somewhat larger.

The performance improvement is rather dramatic, typically between 5x to 20x for real-life volumes.

The patch will be committed in a few weeks if no concerns are raised.

@nnposter
Copy link
Author

@nnposter nnposter commented Aug 31, 2020

The patch has been committed as r37992.

@nmap-bot nmap-bot closed this in 05ad57d Aug 31, 2020
fengjixuchui added a commit to fengjixuchui/nmap that referenced this issue Aug 31, 2020
Speed improvement for script afp-ls. Closes nmap#2098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.