Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nmap 7.90 broken script scan on Windows in UTC+n time zones #2136

Closed
cnotin opened this issue Oct 3, 2020 · 9 comments
Closed

Nmap 7.90 broken script scan on Windows in UTC+n time zones #2136

cnotin opened this issue Oct 3, 2020 · 9 comments
Assignees
Labels

Comments

@cnotin
Copy link

@cnotin cnotin commented Oct 3, 2020

Describe the bug
I get this error in afp.lua and the scan stops:

time result cannot be represented in this installation

To Reproduce
Run a very simple script scan on Windows:

nmap -sC 192.168.0.1
Starting Nmap 7.90 ( https://nmap.org ) at 2020-10-04 00:38 Paris, Madrid (heure d?ÚtÚ)
NSE: Failed to load C:\Program Files (x86)\Nmap/scripts\afp-serverinfo.nse:
C:\Program Files (x86)\Nmap/nselib/afp.lua:353: time result cannot be represented in this installation
stack traceback:
        [C]: in function 'os.time'
        C:\Program Files (x86)\Nmap/nselib/afp.lua:353: in main chunk
        [C]: in function 'require'
        C:\Program Files (x86)\Nmap/scripts\afp-serverinfo.nse:1: in function <C:\Program Files (x86)\Nmap/scripts\afp-serverinfo.nse:1>
NSE: failed to initialize the script engine:
C:\Program Files (x86)\Nmap/nse_main.lua:614: could not load script

Expected behavior
No error :)

Version info (please complete the following information):

  • OS: Windows 10 2004
  • Output of nmap --version:
Nmap version 7.90 ( https://nmap.org )
Platform: i686-pc-windows-windows
Compiled with: nmap-liblua-5.3.5 openssl-1.1.1h nmap-libssh2-1.9.0 nmap-libz-1.2.11 nmap-libpcre-7.6 Npcap-1.00 nmap-libdnet-1.12 ipv6
Compiled without:
Available nsock engines: iocp poll select

Additional context
I have isolated the error from this code:

os.time{year=1970, month=1, day=1, hour=0}

From:

local TIME_OFFSET = os.time{year=2000, month=1, day=1, hour=0} - os.time{year=1970, month=1, day=1, hour=0}

There is no issue on Linux though... It seems to come from how Lua handles dates on Windows like in #1303

Also, but you are probably already aware, the "loslib.c" Lua file is outdated from upstream. I noticed it because in Nmap both os_date and os_time print "time result cannot be represented in this installation" instead of having os_date use "date result cannot..."

"time result cannot be represented in this installation");

https://github.com/lua/lua/blob/9f791535cde1539338f6ba1b9154006595d97fe7/loslib.c#L318

@cnotin cnotin added the Nmap label Oct 3, 2020
@cnotin
Copy link
Author

@cnotin cnotin commented Oct 3, 2020

Interesting thing from mktime on MSDN (emphasis mine)

After an adjustment to UTC, _mktime32 handles dates from midnight, January 1, 1970, to 23:59:59 January 18, 2038, UTC. _mktime64 handles dates from midnight, January 1, 1970 to 23:59:59, December 31, 3000. This adjustment may cause these functions to return -1 (cast to time_t, __time32_t or __time64_t) even though the date you specify is within range. For example, if you are in Cairo, Egypt, which is two hours ahead of UTC, two hours will first be subtracted from the date you specify in timeptr; this may now put your date out of range.

I'm indeed in CEST timezone which is UTC+2

@cnotin
Copy link
Author

@cnotin cnotin commented Oct 3, 2020

I guess os.time{year=1970, month=1, day=1, hour=0} is supposed to be equal to 0 so a simple solution would be to replace it :)

@cnotin
Copy link
Author

@cnotin cnotin commented Oct 3, 2020

Indeed if we execute:

print(os.time{year=2000, month=1, day=1, hour=0} - os.time{year=1970, month=1, day=1, hour=0})

We get "946684800" which is the offset we want as confirmed in Wireshark dissector:
https://github.com/wireshark/wireshark/blob/607831d8706ae32781a4f9176f46cf72414d7b1e/epan/dissectors/packet-afp.c#L1267

cnotin added a commit to cnotin/nmap that referenced this issue Oct 3, 2020
Closes nmap#2136
cnotin added a commit to cnotin/nmap that referenced this issue Oct 3, 2020
cnotin added a commit to cnotin/nmap that referenced this issue Oct 3, 2020
@cnotin cnotin changed the title afp.lua "time result cannot be represented in this installation" error on Windows Nmap 7.90 broken script scan on Windows in UTC+n time zones Oct 3, 2020
@nnposter nnposter self-assigned this Oct 4, 2020
@nnposter nnposter added bug NSE and removed Nmap labels Oct 4, 2020
@nnposter
Copy link

@nnposter nnposter commented Oct 4, 2020

Excellent research into the root cause!

Hopefully fixed in commit r38083.

@nmap-bot nmap-bot closed this in 63c88b1 Oct 4, 2020
@cnotin
Copy link
Author

@cnotin cnotin commented Oct 4, 2020

Thanks! I hope too!

res0nat0r added a commit to res0nat0r/nmap that referenced this issue Oct 7, 2020
stef (#1)
* Implement Ncat proxy creds via environment variable. Fixes nmap#2060, closes nmap#2073

* Fix --resume from IPv6 scans

* Use correct default buffer position. Closes nmap#2084

* Clarify upper boundary for variable-length numerical fields

* Make maximize_fdlimit return rlim_t on appropriate platforms. Closes nmap#2085. Fixes nmap#2079

* Credential object is creds.Account, not brute.Account. See nmap#2086

* Clarify location of the Error object

* Use correct default buffer position. Closes nmap#2086

* Minor optimization of url.parse_query()

* Output of matched fingerprints in http-default-accounts. Fixes nmap#2077

* Document that --open implies --defeat-rst-ratelimit since 7.40

* SNMP scripts are enabled on non-standard ports. See nmap#1473

* Increases SQL Server version resolution

* Eliminate reflection false positives in http-shellshock. Closes nmap#2089

* Unify AFP pathname serialization

* Correct AFP name extraction from responses. Closes nmap#2091
FPGetFileDirParms and FPEnumerateExt2 could crash due to unpacking from
out-of-bounds positions. This latent issue got exposed by converting from
bin.unpack to more stringent string.unpack

* Clarified parsing of the volume list in AFP FPGetSrvrParms

* Add cross references between the 2 whois scripts

* Streamline Boolean expressions

* Centralize AFP timestamp conversion to string

* Fix a word-wrapping issue

* Prevent SSH2 KEX confusion. Fixes nmap#2105

* Add ssh2.fetch_host_key() support for group 16

* Handle case of corrupted TCP options with length 0. Fixes nmap#2104

* Add iDRAC9 fingerprint to http-default-accounts. Closes nmap#2096

* fix license url: http -> https

* Implementation of TLS SNI override in Ncat
Closes nmap#2087, closes nmap#1928, fixes nmap#1927, fixes nmap#1974

* Fix off-by-one issue in last change. Fixes nmap#2107

* Be more strict with TCP options parsing, avoid reading off the end of TCP options. See nmap#2107

* Remove nmap-update

This feature was never publicly released, and has not been distributed
in our binary builds for a couple versions now. It needed to be removed
in order to reduce the number of places Nmap looks for data files. See nmap#2051

* If fetchfile didn't find the XSL, use a relative path on all platforms.

* Do not search NMAPDATADIR on Windows as it is not defined. See nmap#2051

* Remove an unused variable

* Require trailing '/' to match a directory name with --script. See nmap#2051

* Stop using Shellshock in header name. Fixes nmap#1983

* Fix line wrapping

* Speed improvement for script afp-ls. Closes nmap#2098

* New option --discovery-ignore-rst. Closes nmap#1616

* Nbase is needed for __attribute__ on Windows

* include string_pool in Windows build

* Use larger buffer size for socket errors (WSAETIMEDOUT was longer).

* Allow multiple UDP payloads per port. Closes nmap#1859 (payloads to be committed later)

* New UDP payloads. Closes nmap#1860

* Use ASCII chars for some payload data where it makes sense

* Pass error along instead of printing (link error)

* OpenSSL 1.1.X renamed libs: libeay32->libcrypto ssleay32->libssl

* More OpenSSL DLL name changes

* One last libeay32->libcrypto name change

* Fix loopback detection on Windows with new Npcap

* Add some popular favicon hashes

* Update nmap-mac-prefixes

* Update nmap-services from IANA

* Handle too-short response in s7-info. See nmap#2117

* Remove a todo item that is done (--resolve-all)

* Update dated 'class' network terms to CIDR. Closes nmap#2054

* Call superclass's init method from derived class

* Use signed value for tcp header offset and option lengths to detect underflow

* Correctly check for unsigned subtraction underflow.

* Add some missing changelog entries

* Tell LGTM to use the correct version of Python (2)

* Process new Linux and OpenBSD fingerprints

* Only get SSL options if we use them, currently for NO_SSLv2

* Process a few service fingerprint submissions

* Add a requested feature

* Try to make sure enough data is present before parsing. See nmap#2117

* Replace hyphens in the client SSH banner
Hyphen is not allowed in the software version string (RFC 4253, section 4.2)

* Update the SSH protocol flow. Closes nmap#1460
Allows the server to start the key exchange before the protocol version
exchange (banner exchange) is completed

* Silence static analysis warning

LGTM points out that since comparison with sizeof(buf) coerces n to
unsigned, all negative values become very large values, which are
necessarily larger than sizeof(buf), so the test is redundant. We still
want the test in our code to be explicit that we are checking for it, so
reordering the comparisons should silence the warning. A good optimizing
compiler should be able to combine the two conditions anyway.

See github/codeql#4249

* Be explicit about truncating division (timeout is in whole milliseconds)

* Improve docs on -Pn and host discovery

"Host discovery" is the preferred term over "ping scan" because of
confusion with ICMP Echo Request, a.k.a. "ping" as used by the "ping"
utility. Warn when users use -Pn because it has negative impact on scan
times since ultrascan timing parameters fall back to slow initial
defaults.

* Fix a config issue with LGTM (libverbs not linked in libpcap)

* Update IPv6 classifier based on new submissions through 2020-09-14

* Fix a meaningless error message when parsing IPv6 extension headers.

* Allow %F date format to mean YYYY-mm-dd like GNU date

* Remove duplicate test conditionals already tested in enclosing block

* Properly handle pcap reads in iocp engine. Fixes nmap#2126

Still has an odd code smell, but this fixes my test case with Nping.

* Add missing prototype

* Make IOCP the default Nsock engine on Windows. See nmap#2126

* Update macosx build to OpenSSL 1.1.1h, use jhbuild for all build steps

* Default rule base for script mysql-audit. See nmap#2125

* Avoid masked use of date before 1/1/1970 UTC. Fixes nmap#2136, closes nmap#2137

* Fix a CHANGELOG typo

* Reintegrate Nmap 7.90 release branch

* Bump version and regen docs for 7.90SVN post-release

* Only warn about protocol specs in port list with -p. Fixes nmap#2135

* Handle a weird IOCP error for UDP sockets. Fixes nmap#2140

Co-authored-by: nnposter <nnposter@e0a8ed71-7df4-0310-8962-fdc924857419>
Co-authored-by: dmiller <dmiller@e0a8ed71-7df4-0310-8962-fdc924857419>
@fusionneur
Copy link

@fusionneur fusionneur commented Oct 8, 2020

can we have a release on this please? 7.90 is broken on windows

@nnposter
Copy link

@nnposter nnposter commented Oct 8, 2020

See #2141 (comment) for deploying the fix manually.

@dmiller-nmap
Copy link

@dmiller-nmap dmiller-nmap commented Oct 8, 2020

@fusionneur We will likely distribute a bugfix release for Nmap in a week or two once we are done sorting out the few bugs that were reported. Thank you for your patience.

@fyodor
Copy link
Member

@fyodor fyodor commented Oct 14, 2020

Update: this is now fixed in Nmap 7.91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.