Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncat --ssl -l: temporary certificate is only valid for 60 seconds #2167

Closed
girst opened this issue Nov 1, 2020 · 0 comments
Closed

ncat --ssl -l: temporary certificate is only valid for 60 seconds #2167

girst opened this issue Nov 1, 2020 · 0 comments
Assignees

Comments

@girst
Copy link

@girst girst commented Nov 1, 2020

Describe the bug
The temporary certificates generated by --ssl are only valid for 60 seconds. they should be valid for 1 year.

It looks like the error is here

|| X509_gmtime_adj(ta, 60) == 0
, where the magic number 60 is used instead of the previously defined enum value.

To Reproduce

ncat --ssl -l 1234 & sleep 65; openssl s_client -quiet -connect localhost:1234

Expected behavior

The certificate should be valid for one year (or at least, more than 60 seconds).

Version info (please complete the following information):

  • OS: RHEL8, but using the nmap-ncat package from nmap.org/dist
  • Output of ncat --version: Ncat: Version 7.91 ( https://nmap.org/ncat )

Additional context

@girst girst added the Ncat label Nov 1, 2020
girst pushed a commit to fork-graveyard/nmap that referenced this issue Nov 1, 2020
girst added a commit to fork-graveyard/nmap that referenced this issue Nov 1, 2020
girst pushed a commit to fork-graveyard/nmap that referenced this issue Nov 1, 2020
@nnposter nnposter self-assigned this Dec 23, 2020
@nnposter nnposter added the bug label Dec 23, 2020
@nmap-bot nmap-bot closed this in 9334c9f Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants