Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Missing support for TLS server_name on Windows #700
When running on Windows, Nsock currently does not provide support for TLS extension
The core reason appears to be that there is no
All these files contain an unconditional disposition that OpenSSL is available:
#define HAVE_OPENSSL 1
However, none provides any hint about the availability of TLS extension
#define HAVE_SSL_SET_TLSEXT_HOST_NAME 1
Note that there is only one location in the entire codebase where
The obvious quick-fix remediation is to add this
I have done so in my copy of the source code, confirming that doing so does rectify the original problem.
That said, it is unclear to me why it is necessary to test explicitly for the existence of the extension...
...instead of assuming its availability based on
I would be happy to put in either fix. The first one is dead-simple but the second one seems to be the right way to address it. Opinions?
If I do not get any feedback I will commit the first fix in a few weeks.
I tend to agree that we don't need to worry greatly about supporting ancient versions of OpenSSL, but we do generally support old and unusual configurations that could be problematic if we made it unconditional. Since we are stricter about what Windows build configurations we support, let's go with your initial fix (adding the