Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npcap: when winpcap installed then winpcap_mode cmdline param is not respected #717

Closed
narspt opened this issue Mar 2, 2017 · 1 comment
Closed

Comments

@narspt
Copy link

@narspt narspt commented Mar 2, 2017

When Npcap installer finds Winpcap installed on system then it forces compatible mode checkbox to unchecked state, thus not respecting and completely ignoring /winpcap_mode command line param.

I did check old installer script (as the new one is not available on the repo anymore?) and despite I'm not familiar with nsis, I really guess the middle line below does just that:

	WriteINIStr "$PLUGINSDIR\options.ini" "Field 8" "Text" "Npcap detected you have installed WinPcap, in order to Install Npcap \r\nin WinPcap API-compatible Mode, WinPcap will be uninstalled first."
	WriteINIStr "$PLUGINSDIR\options.ini" "Field 7" "State" 0
	WriteINIStr "$PLUGINSDIR\options.ini" "Field 7" "Text" "Install Npcap in WinPcap API-compatible Mode (WinPcap will be uninstalled)"

Now that compatible mode is off by default on Npcap, could you please consider removing that line and allowing it to respect the command line param?

Or... if you really want to keep the current behavior for some reason, could you please add some other param to allow forcing/overriding it? But honestly I don't see why this would be required, if a command line param is set to specifically install with compatible mode enabled then that is desired/needed and I guess it should be respected, incl. uninstall Winpcap if present.

Btw, I did also notice that the documented 'enforced' value for params don't work at all, despite there is code to make them work they are "filtered" on the getInstallOptions function... not sure if this was some intended change (and documentation is outdated in that case) or a bug?

@narspt narspt changed the title when winpcap installed then winpcap_mode cmdline param is not respected npcap: when winpcap installed then winpcap_mode cmdline param is not respected Mar 2, 2017
@narspt
Copy link
Author

@narspt narspt commented Mar 6, 2017

I can confirm that /winpcap_mode override is fixed on 0.83, thank you.

Concerning 'enforced' values they are still ignored, not sure if intended? (but they are still listed on documentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant