New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Makefiles #75

Open
dmiller-nmap opened this Issue Mar 10, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@dmiller-nmap

dmiller-nmap commented Mar 10, 2015

Our sub-projects (Ncat, Nping, Zenmap, Ndiff, and nmap-update) and included libraries (libpcap, libpcre, liblua, libnetutil, nbase, nsock, libdnet-stripped) use different spellings and arrangement of directives, variables, and dependencies, but really all do nearly the same thing. Example:

all: @LUA_BUILD@ @LIBLINEAR_BUILD@ @PCAP_BUILD@ @PCRE_BUILD@ @DNET_BUILD@ @NBASE_BUILD@ @NSOCK_BUILD@ @NCAT_BUILD@ @NMAP_UPDATE_BUILD@ netutil_build
  $(MAKE) $(TARGET) $(BUILDZENMAP) $(BUILDNDIFF) $(BUILDNPING)

In this example, why does libnetutil not use an AC_SUBST expansion, but nbase does? Why do Ncat and nmap-update use AC_SUBST expansions and not a Makefile variable like $(BUILDNCAT)? Later in the file, why is it ncat_build but build-nping?

The targets are also interspersed: sometimes the clean-* targets are all together, other times it's grouped by project name.

@dmiller-nmap

This comment has been minimized.

Show comment
Hide comment
@dmiller-nmap

dmiller-nmap Mar 10, 2015

At the risk of bloating an already broad task, a lot of our stuff breaks with large -j values to make.

dmiller-nmap commented Mar 10, 2015

At the risk of bloating an already broad task, a lot of our stuff breaks with large -j values to make.

@G10h4ck

This comment has been minimized.

Show comment
Hide comment
@G10h4ck
Contributor

G10h4ck commented Jul 22, 2015

@boite

This comment has been minimized.

Show comment
Hide comment
@boite

boite Sep 18, 2015

@G10h4ck are you still working on this issue? If not, and if @dmiller-nmap (or is it @bonsaiviking ) isn't, then I'd like to do a bit more towards it: there's still some un-interspersing that can be done along with more conversions of AC_SUBST expansions to Makefile variables.

boite commented Sep 18, 2015

@G10h4ck are you still working on this issue? If not, and if @dmiller-nmap (or is it @bonsaiviking ) isn't, then I'd like to do a bit more towards it: there's still some un-interspersing that can be done along with more conversions of AC_SUBST expansions to Makefile variables.

@G10h4ck

This comment has been minimized.

Show comment
Hide comment
@G10h4ck

G10h4ck Sep 18, 2015

Contributor

Nope I am not working on it right now, so you are welcome to continue fixing this ;)

Contributor

G10h4ck commented Sep 18, 2015

Nope I am not working on it right now, so you are welcome to continue fixing this ;)

qha added a commit to qha/nmap that referenced this issue Dec 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment