Fix #839 — Correctly pass arguments to Zenmap #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoNaNoW
commented
Nov 29, 2017
WoNaNoW
commented
- Modify zenmap_auth.m to parse arguments and pass them to AppleScript.
- Arguments are now passed from the zenmap.bin invocation to the zenmap (Python) command.
WoNaNoW
changed the title
WoNaNoW
commented
Nov 29, 2017
| @@ -41,14 +41,17 @@ if [ -z ${lang+x} ]; then | |||
| export LANG="`echo $lang`.UTF-8" | |||
| fi | |||
|
|
|||
Author
There was a problem hiding this comment.
The following lines were actually a leftover that I wrote a while ago to debug the chosen language.
|
@WoNaNoW Great to hear from you again! I'll be looking at this shortly, but can you either explain or move the documentation and jhbuild modules changes to a different pull request? That way we can discuss them individually. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.