Add Eclipse Equinoxe OSGi console fingerprint.#1123
Open
qkaiser wants to merge 1 commit intonmap:masterfrom
Open
Add Eclipse Equinoxe OSGi console fingerprint.#1123qkaiser wants to merge 1 commit intonmap:masterfrom
qkaiser wants to merge 1 commit intonmap:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add fingerprints for OSGi console from Eclipse Equinoxe. Some Java middlewares are now exposing an "OSGi console" over Telnet. This commit add fingerprints for this telnet service.
To test it locally, you can follow the Eclipse guide (see first reference) or use my setup script at https://gist.github.com/QKaiser/66c8a618eef2a7801c0bbb1aa43d724a
OSGi consoles can work in two modes:
java -jar org.eclipse.osgi.jar -console <port>telnetd starton OSGi consoleDirect mode enforce terminal type negotiation "IAC Do Terminal Type" (hence the first fingerprint) while telnetd mode greets the client with
osgi>(hence the second fingerprint).References