osgi-info.nse script - gather system information via OSGi console

[qkaiser]

This NSE scripts connects to an OSGi console and use the getprop command to retrieve:

• username running the service
• complete OS version
• complete Java VM and Runtime versions

For more information about OSGi, you can check pull request #1123

[cldrn]

Thank you for contributing. The script looks great, although the bin library is deprecated and we prefer scripts to use the string library in Lua 5.3 for pack/unpack. Do you still have access to the server? Can you replace the library and test it again without deprecated libraries?

[qkaiser]

I still have access to the server, I'll update the script sometime today.

[qkaiser]

Done. Updated the script so it uses string.pack instead of bin.pack

[cldrn]

Thanks again for contributing! The script looks good to me. The only two things that would be great to include are:

• Always specify the endianness when packing/unpacking data. See a few pointers from bonsaiviking about migrating from bin.lua to string
• Can you include the tag xmloutput since you are already using output tables?

[qkaiser]

• @xmloutput added
• endianness explicitly specified when packing

Let me know if this works for you :)