New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default proxy type if port number was not specified. #1139

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@landgraf

landgraf commented Feb 17, 2018

Because of regression in SOCKS5 patch default proxy port was
set to http proxy even if proxy-type socks[45] was specified.

Set default proxy type if port number was not specified.
Because of regression in SOCKS5 patch default proxy port was
set to http proxy even if proxy-type socks[45] was specified.
@nnposter

This comment has been minimized.

nnposter commented Mar 5, 2018

Committed as r37156 with just a trivial tweak: The initial assignment is no longer needed:

unsigned short proxyport = DEFAULT_PROXY_PORT;

Thank you for your contribution.

@nmap-bot nmap-bot closed this in 6822058 Mar 5, 2018

@landgraf landgraf deleted the landgraf:default_proxy_port branch Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment