Check for parse_ssl_certificate method before use - #115
Closed
jrchamp wants to merge 1 commit into
Closed
Conversation
Avoid immediate exit when the parse_ssl_certificate method is not defined.
|
I agree that we should gracefully handle the case where openssl is not included. But I don't think that we can meaningfully report a handshake score without parsing the certificate. I'd accept a patch that does either of these:
|
|
is any pull request send at Github would be merged to svn official repository ? |
|
@ryanchou1991 see #127. |
|
@p-l- I got it, Thanks :) I will make my contribution to this project all my best effort: ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid immediate exit when the parse_ssl_certificate method is not defined.