Check for parse_ssl_certificate method before use #115

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

jrchamp commented May 14, 2015

Avoid immediate exit when the parse_ssl_certificate method is not defined.

@jrchamp jrchamp Check for parse_ssl_certificate method before use
Avoid immediate exit when the parse_ssl_certificate method is not defined.
43a8565

I agree that we should gracefully handle the case where openssl is not included. But I don't think that we can meaningfully report a handshake score without parsing the certificate. I'd accept a patch that does either of these:

  1. detects the missing function at the beginning of execution and does not display or calculate a score, but simply reports the ciphersuites discovered, or
  2. replaces the OpenSSL X509 parser with one written in Lua.

is any pull request send at Github would be merged to svn official repository ?

p-l- commented May 26, 2015

@ryanchou1991 see #127.

nmap-bot closed this in 29f57ea Jul 4, 2015

@p-l- I got it, Thanks :) I will make my contribution to this project all my best effort: )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment