Skip to content

Check for parse_ssl_certificate method before use - #115

Closed
jrchamp wants to merge 1 commit into
nmap:masterfrom
jrchamp:patch-1
Closed

Check for parse_ssl_certificate method before use#115
jrchamp wants to merge 1 commit into
nmap:masterfrom
jrchamp:patch-1

Conversation

@jrchamp

@jrchamp jrchamp commented May 14, 2015

Copy link
Copy Markdown

Avoid immediate exit when the parse_ssl_certificate method is not defined.

Avoid immediate exit when the parse_ssl_certificate method is not defined.
@dmiller-nmap

Copy link
Copy Markdown

I agree that we should gracefully handle the case where openssl is not included. But I don't think that we can meaningfully report a handshake score without parsing the certificate. I'd accept a patch that does either of these:

  1. detects the missing function at the beginning of execution and does not display or calculate a score, but simply reports the ciphersuites discovered, or
  2. replaces the OpenSSL X509 parser with one written in Lua.

@jkryanchou

Copy link
Copy Markdown

is any pull request send at Github would be merged to svn official repository ?

@p-l-

p-l- commented May 26, 2015

Copy link
Copy Markdown

@ryanchou1991 see #127.

@nmap-bot nmap-bot closed this in 29f57ea Jul 4, 2015
@jkryanchou

Copy link
Copy Markdown

@p-l- I got it, Thanks :) I will make my contribution to this project all my best effort: )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants