Change how host timeouts are initialized in ultrascan.#1150
Closed
jsiembida wants to merge 1 commit intonmap:masterfrom
Closed
Change how host timeouts are initialized in ultrascan.#1150jsiembida wants to merge 1 commit intonmap:masterfrom
jsiembida wants to merge 1 commit intonmap:masterfrom
Conversation
When targets are subject to congestion control, their timeout clocks should not be initialized to the same time, otherwise they are being completed without even trying. Command that triggers the issue in AWS: nmap -sT -T3 --host-timeout 5 -n --max-hostgroup 100 -Pn -p 8080 a.b.c.d/24
|
This is an interesting idea. I can see how the existing behavior could be a problem. I will have to do more review and testing to see if this is a complete fix, but for now, here are my concerns:
|
Author
|
|
I've made slight adjustments and will be committing this soon. Would you like a different name or full name credit in the CHANGELOG, or just your Github username? |
Author
|
I am happy with whatever is more convenient to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When targets are subject to congestion control, their timeout clocks
should not be initialized to the same time, otherwise they are being
completed without even trying. Command that triggers the issue in AWS:
nmap -sT -T3 --host-timeout 5 -n --max-hostgroup 100 -Pn -p 8080 a.b.c.d/24