Fix table input for http-grep.match arg #1158

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@hansbogert

Checking the http-grep argument is now accurately against a table string instead table keyword.
The index for the matching table was also incorrect due to erroneous extra spaces.

Fix table input for http-grep.match arg
Checking the http-grep argument is now accurately against a table string instead table keyword. 
The index for the matching table was also incorrect due to erroneous extra spaces.

@nmap-bot nmap-bot closed this in 02e3add Mar 28, 2018

@hansbogert

This comment has been minimized.

Show comment Hide comment
@hansbogert

hansbogert Apr 9, 2018

  1. A little feedback wouldn't hurt
  2. You merge in my changes without giving due credit (Unless the changelog is updated later in the process, but I don't see it)
  3. You only apply half of the patch? The whitespace change really makes a difference.

hansbogert commented Apr 9, 2018

  1. A little feedback wouldn't hurt
  2. You merge in my changes without giving due credit (Unless the changelog is updated later in the process, but I don't see it)
  3. You only apply half of the patch? The whitespace change really makes a difference.
@dmiller-nmap

This comment has been minimized.

Show comment Hide comment
@dmiller-nmap

dmiller-nmap Apr 10, 2018

@hansbogert I'm sorry, the commit in question wasn't complete. I split the change into the two separate issues it fixes because I found multiple instances of type(x) being compared to non-strings, but time intervened and the whitespace part and changelog credit were never applied. I've fixed it in an upcoming commit. Thanks for your help!

@hansbogert I'm sorry, the commit in question wasn't complete. I split the change into the two separate issues it fixes because I found multiple instances of type(x) being compared to non-strings, but time intervened and the whitespace part and changelog credit were never applied. I've fixed it in an upcoming commit. Thanks for your help!

nmap-bot pushed a commit that referenced this pull request Apr 10, 2018

@hansbogert hansbogert deleted the hansbogert:patch-1 branch Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment