Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix name resolution for socks4 proxy. #1214
Previously client didn't try to resolve hostname prior to sending
Previously client didn't try to resolve hostname prior to sending request to proxy. It violates SOCKS4a specification which says DSTIP should be set to .X if client cannot resolve the destination host and may be problematic in some environments. This behaviour can be overriden with --nodns option (to force client to use socks4a extention); Bug-Url: https://bugzilla.redhat.com/1573148
The change, if I understand it correctly, would substantially break backwards compatibility. Namely, I can currently connect like this:
which performs remote DNS lookup of
which will fail, because
I believe that a better approach could be to decouple hostname resolution of proxy destinations from all the other resolutions, which need to be inherently done locally.
Could you please take a look at #1439 and let me know if it would meet your needs?