Update to display vuln obj to user for CVE2006-3392 #1220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the function would return vuln_report:make_output(detection_session.body). The expected output is that the nmap scan finishes and shows the "vuln" structure (title, state, IDs, description) if the instance is vulnerable. This was not the case when run against a vulnerable instance (pwnOs1 vulnerable VM). The nmap script would finish and not display anything to the user unless --script-trace or -d flags were set. After updating make_output to make_output(vuln), the finished nmap scan correctly displays the vuln structure after completion. A further enhancement could be made to add detection_session.body to the vuln obj.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Previously, the function would return vuln_report:make_output(detection_session.body).
The expected output is that the nmap scan finishes and shows the "vuln" structure (title, state, IDs, description) if the instance is vulnerable.
This was not the case when run against a vulnerable instance (pwnOs1 vulnerable VM). The nmap script would finish and not display anything to the user unless --script-trace or -d flags were set.
After updating make_output to make_output(vuln), the finished nmap scan correctly displays the vuln structure after completion.
A further enhancement could be made to add detection_session.body to the vuln obj.