/nmap

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null values in case IP is not found on geoplugin. #1331

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@nnposter nnposter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mkubenka @nnposter
@mkubenka

mkubenka commented Sep 19, 2018

No description provided.

@mkubenka
Handle null values in case IP is not found on geoplugin.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
8f6b207
@nnposter

nnposter reviewed Sep 20, 2018
View changes

I see the issue but I am wondering if this is the right way to handle it.

Would it not be perhaps more appropriate to return nil, instead of returning dummy coordinates? They might work fine for direct human consumption but less so for further scripted processing.

Opinion?

@nmap-bot nmap-bot closed this in 74f1b37 Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment