Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upconfigure.ac: fix search for lua #1355
Closed
Conversation
When cross-compiling, paths such as /usr/include are not allowed and will raise an error so don't use them when searching for lua. Indeed, when cross-compilnig, the user can use the --with-liblua option to specify a path that will put in CPPFLAGS. If the library is not found without these paths, keep current code as a fallback Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
This comment has been minimized.
This comment has been minimized.
dmiller-nmap
commented
Oct 14, 2018
|
Thanks for reporting this! There are still problems with Lua detection that
I will be fixing as a result of your report. Watch for some changes soon.
|
nmap-bot
pushed a commit
that referenced
this pull request
Oct 16, 2018
We will need to do something similar for Ncat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ffontaine commentedOct 13, 2018
When cross-compiling, paths such as /usr/include are not allowed and
will raise an error so don't use them when searching for lua.
Indeed, when cross-compilnig, the user can use the --with-liblua option
to specify a path that will put in CPPFLAGS.
If the library is not found without these paths, keep current code as a
fallback
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com