fix: vuln check in http-phpmyadmin-dir-traversal

[phra]

it adds an additional check against a baseline response.

fixes #1358

[dmiller-nmap]

The failing check here is my fault; the build was broken in the commit you branched from. I'm looking at your changes now.

[phra]

hi @dmiller-nmap,
the PR was closed by @nmap-bot, should i resend it?

[dmiller-nmap]

@phra No, I applied your change with slight modifications in the commit that closed this PR. If you can confirm that the change works and you no longer get a false positive, we can also close #1358 .

[phra]

@dmiller-nmap nmap is released under GPL2 LICENSE AFAIK. the ownership (mention of the author) of the commits should remain of the original authors. please review the way you integrate community contributions respecting your own LICENSE and the open source community efforts.

[dmiller-nmap]

@phra Thanks for your concern. For the moment, our process is documented in CONTRIBUTING.md, and is consistent with how Nmap development has been done for decades: commits made by authorized committers with appropriate credit given to original code authors in the CHANGELOG file. I will bring this issue up to @fyodor as well.

[dmiller-nmap]

@phra Thanks for your concern. For the moment, our process is documented in CONTRIBUTING.md, and is consistent with how Nmap development has been done for decades: commits made by authorized committers with appropriate credit given to original code authors in the CHANGELOG file. I will bring this issue up to @fyodor as well.

[dmiller-nmap]

@phra Thanks for your concern. For the moment, our process is documented in CONTRIBUTING.md, and is consistent with how Nmap development has been done for decades: commits made by authorized committers with appropriate credit given to original code authors in the CHANGELOG file. I will bring this issue up to @fyodor as well.

[dmiller-nmap]

@phra Thanks for your concern. For the moment, our process is documented in CONTRIBUTING.md, and is consistent with how Nmap development has been done for decades: commits made by authorized committers with appropriate credit given to original code authors in the CHANGELOG file. I will bring this issue up to @fyodor as well.

[dmiller-nmap]

wow, Github was having problems last night and apparently queued this comment every time I tried to comment it, but told me nothing was happening. Sorry about that!

[phra]

ahah, no problem :)