New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to prevent connections to get terminated while still on going #1372

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@illera88

illera88 commented Oct 25, 2018

I don't know how people could use it before this commit.

Connections get finished whenever the result from WaitForMultipleObjects errors to ERROR_IO_INCOMPLETE.

Testing:
Listen with:
ncat.exe -lvp 4444 --ssl

Connect with:
ncat.exe 127.0.0.1 4444 -e cmd.exe --ssl -v.

Run any command (i.e. dir) and it will close the connection.

Standard error is reported in the client and not in the server but I'll open a ticket to fix that.

Cheers

EDIT: stderr issue: #1373

Fix to prevent connections to get terminated while still on going
I don't know how people could use it before this
@dmiller-nmap

This comment has been minimized.

dmiller-nmap commented Oct 26, 2018

Thanks for the patch! This error is not mentioned in the "Return value" section of the documentation for GetOverlappedResult, but instead is up in the discussion of the bWarn parameter, so I had missed it. I modified your patch to use a switch statement, which I prefer for multiple comparisons of error values, but I credited you with the fix in the Changelog.

@nmap-bot nmap-bot closed this in 86d1f7e Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment