Skip to content

Fix status.format error in smb scripts - #1714

Closed
vanjo9800 wants to merge 1 commit into
nmap:masterfrom
vanjo9800:fix_strings_format_status
Closed

vanjo9800 wants to merge 1 commit into
nmap:masterfrom
vanjo9800:fix_strings_format_status

Conversation

@vanjo9800

Copy link
Copy Markdown

Remove local declaration of status variable that shadows the global one inside the loop and therefore an invalid parameter is passed to get_status_name() in smb.lua.

@nnposter

nnposter commented Sep 6, 2019

Copy link
Copy Markdown

I have committed your fix as r37730 with a slight modification: You have forgotten to remove the string.unpack operation from the line where you declare the additional variables.

Thank you for contributing to nmap by identifying the issue and the root cause!

@nmap-bot nmap-bot closed this in ce28753 Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants