Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncat: Added --ssl-servername option to specify hostname to request #1928

Closed
wants to merge 1 commit into from

Conversation

@hlein
Copy link

@hlein hlein commented Feb 17, 2020

nsock_iod_set_hostname is accessible in nse code, but I could not find a
knob to use it with ncat. This patch adds --ssl-servername to ncat.

With this patch, using the example from issue #1927:

  $ echo -n -e 'GET / HTTP/1.0\r\nHost: servername\r\n\r\n' | \
      ncat -n -v --ssl --ssl-servername servername 10.1.2.3 443
  HTTP/1.1 200 OK

Signed-off-by: Hank Leininger hlein@korelogic.com
Closes: #1927

nsock_iod_set_hostname is accessible in nse code, but I could not find a
knob to use it with ncat.  This patch adds --ssl-servername to ncat.

With this patch, using the example from issue #1927:

```
  $ echo -n -e 'GET / HTTP/1.0\r\nHost: servername\r\n\r\n' | \
      ncat -n -v --ssl --ssl-servername servername 10.1.2.3 443
  HTTP/1.1 200 OK
```

Signed-off-by: Hank Leininger <hlein@korelogic.com>
Closes: #1927
@hlein hlein requested a review from dmiller-nmap Feb 23, 2020
@hlein
Copy link
Author

@hlein hlein commented Jul 16, 2020

@nnposter could you review this and the related issue please? Thanks!

@nnposter nnposter self-assigned this Jul 20, 2020
@nnposter
Copy link

@nnposter nnposter commented Jul 20, 2020

The key change looks fine but more is needed for a complete implementation. I should have a patch for you to try in a few days.

@hlein
Copy link
Author

@hlein hlein commented Jul 20, 2020

The key change looks fine but more is needed for a complete implementation. I should have a patch for you to try in a few days.

Oh cool, thanks!

@nnposter
Copy link

@nnposter nnposter commented Jul 21, 2020

Please test #2087 and report back any issues

@nmap-bot nmap-bot closed this in 7d6cf3a Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.