Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version detection: Update multiple database fingerprints #1963

Closed
wants to merge 1 commit into from

Conversation

@TomSellers
Copy link

TomSellers commented Mar 11, 2020

This PR:

  • Adds coverage for MySQL 8.x
  • Adds coverage for Microsoft SQL Server 2019
  • Adds specific coverage for MariaDB
  • Tunes PostgreSQL version ranges to reflect a few newer versions
  • Adds coverage for recent versions of PostgreSQL running in Docker on the alpine image.
    • The switch from alpine 3.10 to 3.11 and/or LLVM 8 to 9 resulted in line number changes for the last 2 versions of the Docker images for each PostgreSQL train on alpine.
  • Adds coverage for Crate.io's CrateDB.
  • Adds cpe values for a couple of Redis matches

Crate.io CrateDB

Testing target

docker run -p 4200:4200 crate

Sample output

PORT     STATE SERVICE     REASON         VERSION
4200/tcp open  http        syn-ack ttl 64 Crate.io CrateDB 4.1.2 (Cluster name: crate, Lucene version: 8.4.0)

# PostgreSQL - Docker image - most docker images have the same error message as the release version, these do not.
# Seems images build after the move to from Alpine 3.10 to 3.11 have changed line numbers.
# PR where this behavior starts: https://github.com/docker-library/postgres/pull/657

This comment has been minimized.

Copy link
@TomSellers

TomSellers Mar 11, 2020

Author

I was concerned that the Docker images had been tampered with. I found the official repo from which the images were generated (https://github.com/docker-library/postgres/tree/master/12/alpine) and was able to

  • verify that the image used the official release
  • that the line number in the error message matched prior to but not after, the 3 commits that bumped alpine to 3.11, adjusted the user creation, and upgraded LLVM.

This comment has been minimized.

Copy link
@TomSellers

TomSellers Mar 31, 2020

Author

PR where the change likely happened: docker-library/postgres#657

@TomSellers
Copy link
Author

TomSellers commented Mar 31, 2020

PR landed in SVN via r37918. This ticket didn't auto-close because I typo'd the commit message.

@TomSellers TomSellers closed this Mar 31, 2020
@TomSellers TomSellers deleted the TomSellers:update_db_fps branch Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.