Version detection: Update multiple database fingerprints #1963
+35
−16
Conversation
|
||
# PostgreSQL - Docker image - most docker images have the same error message as the release version, these do not. | ||
# Seems images build after the move to from Alpine 3.10 to 3.11 have changed line numbers. | ||
# PR where this behavior starts: https://github.com/docker-library/postgres/pull/657 |
TomSellers
Mar 11, 2020
Author
I was concerned that the Docker images had been tampered with. I found the official repo from which the images were generated (https://github.com/docker-library/postgres/tree/master/12/alpine) and was able to
- verify that the image used the official release
- that the line number in the error message matched prior to but not after, the 3 commits that bumped alpine to 3.11, adjusted the user creation, and upgraded LLVM.
I was concerned that the Docker images had been tampered with. I found the official repo from which the images were generated (https://github.com/docker-library/postgres/tree/master/12/alpine) and was able to
- verify that the image used the official release
- that the line number in the error message matched prior to but not after, the 3 commits that bumped alpine to 3.11, adjusted the user creation, and upgraded LLVM.
PR landed in SVN via r37918. This ticket didn't auto-close because I typo'd the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR:
alpine
image.alpine 3.10
to3.11
and/or LLVM 8 to 9 resulted in line number changes for the last 2 versions of the Docker images for each PostgreSQL train onalpine
.cpe
values for a couple of Redis matchesCrate.io CrateDB
Testing target
Sample output