Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated CPEs for Microsoft IIS. #2401 #2402

Merged
merged 1 commit into from Dec 7, 2021
Merged

Replace deprecated CPEs for Microsoft IIS. #2401 #2402

merged 1 commit into from Dec 7, 2021

Conversation

oh2fih
Copy link
Contributor

@oh2fih oh2fih commented Nov 25, 2021

Replaces all cpe:/a:microsoft:internet_information_server with cpe:/a:microsoft:internet_information_services in Nmap service probes.

Closes #2401

@dmiller-nmap dmiller-nmap merged commit dc59413 into nmap:master Dec 7, 2021
dmiller-nmap added a commit that referenced this issue Dec 7, 2021
@nnposter
Copy link

@nnposter nnposter commented Dec 7, 2021

@dmiller-nmap I have noticed that this PR was merged directly, instead of imported into SVN. The SVN, currently at r38312, does not have the corresponding change. Does it mean that the GitHub repo is now the master?

@oh2fih
Copy link
Contributor Author

@oh2fih oh2fih commented Dec 10, 2021

I was wondering the same. According to CONTRIBUTING.md, GitHub should be used for pull requests. The changes are manually added to the Subversion repository and synced back from there. However, the document also states that the GitHub repository should be read only.

In my opinion the documented workflow seems a bit laborious, and it also hides all the people contributing to the project, so I hope this is not just a mistake, but a new beginning.

@dmiller-nmap
Copy link

@dmiller-nmap dmiller-nmap commented Dec 13, 2021

Unfortunately, I just made a mistake in doing it this way. We're still not set up to make commits directly to Github. I'll have to clobber this one in order to allow SVN to sync again, then make a separate commit to SVN with a credit in the CHANGELOG for @oh2fih.

mzet- pushed a commit to mzet-/Nmap-for-Pen-Testers that referenced this issue Dec 20, 2021
@nmap nmap deleted a comment Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants