Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify OpenSSL even if custom location is requested #2436

Closed
wants to merge 1 commit into from
Closed

Verify OpenSSL even if custom location is requested #2436

wants to merge 1 commit into from

Conversation

nnposter
Copy link

@nnposter nnposter commented Jan 30, 2022

The patch is intended to fix #2420. Specifically, it implements these changes:

  • Moves existing AC_SEARCH_LIBS(dlopen, dl) forward, so that libdl is available for linking when OpenSSL tests are carried out.
  • Performs existing OpenSSL header and library tests even if custom library location is specified via --with-openssl=somedir.
  • Prints appropriate error messages if these tests fail, differentiating between --with-openssl=somedir and --with-openssl=yes

As a result:

  • OpenSSL issues with custom library locations are detected earlier, at configure time, instead of during make.
  • Presence or absence of ECC support is correctly configured (#2420)

Please review and comment. Note that the logical patch is rather tiny. Most of the delta is caused by different indentation of existing code.

If no issues are raised, this PR will be committed on or after March 1st.

@nnposter
Copy link
Author

@nnposter nnposter commented Mar 3, 2022

The fix has been committed as r38364.

@nmap nmap deleted a comment Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant