Catch errors when connecting to SSH servers in ssh-publickey-acceptance.nse. Fixes #1014 - #2616
Closed
MegaManSec wants to merge 4 commits into
Closed
Catch errors when connecting to SSH servers in ssh-publickey-acceptance.nse. Fixes #1014#2616MegaManSec wants to merge 4 commits into
MegaManSec wants to merge 4 commits into
Conversation
…ce.nse ssh-publickey-acceptance.nse attempts to connect to remote SSH servers, and if it cannot connect, it tries a total of three times per host. However, connect() raises an exception, thus bailing completely on the host. connect_plist() returns the status however, and the re-attempts will occur.
MegaManSec
changed the title
Author
|
Looks great. I combined this with some similar changes to the other SSH scripts and credited you in the changelog. The commit will close this PR when it syncs. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssh-publickey-acceptance.nse attempts to connect to remote SSH servers, and if it cannot connect, it tries a total of three times per host. However, connect() raises an exception, thus bailing completely on the host. connect_plist() returns the status however, and the re-attempts will occur.
I have also changed the verbose message about acepted keys to include the host. I have also included the privatekey name in case of failure to use the key.