New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zenmap][GUI] added topology legend button. #279

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@srjhnd

srjhnd commented Jan 18, 2016

As suggested in the issue #258 by @dmiller-nmap I added a topology "legend" button to the Toolbar. Also added an image
(legend.png) to the pixmaps folder

@dmiller-nmap

This comment has been minimized.

Show comment
Hide comment
@dmiller-nmap

dmiller-nmap Jan 21, 2016

@surajhande555 Thanks for contributing! I guess I should have been clearer with the requirements for this option. I don't think a static image will be sufficient, since we need it to look good in varying screen resolutions/sizes and to be easy to update when/if we change the images. Check back on #258 soon and I will put some notes there.

dmiller-nmap commented Jan 21, 2016

@surajhande555 Thanks for contributing! I guess I should have been clearer with the requirements for this option. I don't think a static image will be sufficient, since we need it to look good in varying screen resolutions/sizes and to be easy to update when/if we change the images. Check back on #258 soon and I will put some notes there.

@srjhnd

This comment has been minimized.

Show comment
Hide comment
@srjhnd

srjhnd Jan 31, 2016

@dmiller-nmap I've written a LegendWindow class with all the shapes and labels drawn independently as you said.
Please review and let me know.

srjhnd commented Jan 31, 2016

@dmiller-nmap I've written a LegendWindow class with all the shapes and labels drawn independently as you said.
Please review and let me know.

@dmiller-nmap

This comment has been minimized.

Show comment
Hide comment
@dmiller-nmap

dmiller-nmap Jun 25, 2016

@srjhnd Thanks so much for doing this! I made a few changes to bring it in line with our code conventions, but overall this is your code and you get all the credit. Changes:

  • Fixed whitespace issues (trailing, tab indents instead of spaces)
  • PEP8 warnings addressed
  • Factored out some common drawing code into separate functions to clarify and avoid errors
  • Relative layout by adjusting y-coordinate makes it easier to add new elements
  • Support for translation by wrapping translatable strings in _()
  • Minor layout adjustments

dmiller-nmap commented Jun 25, 2016

@srjhnd Thanks so much for doing this! I made a few changes to bring it in line with our code conventions, but overall this is your code and you get all the credit. Changes:

  • Fixed whitespace issues (trailing, tab indents instead of spaces)
  • PEP8 warnings addressed
  • Factored out some common drawing code into separate functions to clarify and avoid errors
  • Relative layout by adjusting y-coordinate makes it easier to add new elements
  • Support for translation by wrapping translatable strings in _()
  • Minor layout adjustments

@nmap-bot nmap-bot closed this in c52d865 Jun 25, 2016

tremblerz added a commit to tremblerz/nmap that referenced this pull request Jul 20, 2016

tremblerz added a commit to tremblerz/nmap that referenced this pull request Jul 21, 2016

batrick pushed a commit to batrick/nmap that referenced this pull request Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment