[zenmap][GUI] added topology legend button. #279

Closed
wants to merge 4 commits into
from

Projects

None yet

2 participants

@srjhnd
srjhnd commented Jan 18, 2016

As suggested in the issue #258 by @dmiller-nmap I added a topology "legend" button to the Toolbar. Also added an image
(legend.png) to the pixmaps folder

@dmiller-nmap

@surajhande555 Thanks for contributing! I guess I should have been clearer with the requirements for this option. I don't think a static image will be sufficient, since we need it to look good in varying screen resolutions/sizes and to be easy to update when/if we change the images. Check back on #258 soon and I will put some notes there.

@srjhnd
srjhnd commented Jan 31, 2016

@dmiller-nmap I've written a LegendWindow class with all the shapes and labels drawn independently as you said.
Please review and let me know.

@dmiller-nmap

@srjhnd Thanks so much for doing this! I made a few changes to bring it in line with our code conventions, but overall this is your code and you get all the credit. Changes:

  • Fixed whitespace issues (trailing, tab indents instead of spaces)
  • PEP8 warnings addressed
  • Factored out some common drawing code into separate functions to clarify and avoid errors
  • Relative layout by adjusting y-coordinate makes it easier to add new elements
  • Support for translation by wrapping translatable strings in _()
  • Minor layout adjustments
@nmap-bot nmap-bot closed this in c52d865 Jun 25, 2016
@tremblerz tremblerz added a commit to tremblerz/nmap that referenced this pull request Jul 20, 2016
@bonsaiviking @tremblerz bonsaiviking + tremblerz Add legend for Topography window. Closes #279, Fixes #258 43f0921
@tremblerz tremblerz added a commit to tremblerz/nmap that referenced this pull request Jul 21, 2016
@bonsaiviking @tremblerz bonsaiviking + tremblerz Add legend for Topography window. Closes #279, Fixes #258 7e843be
@batrick batrick pushed a commit to batrick/nmap that referenced this pull request Aug 2, 2016
@bonsaiviking bonsaiviking Add legend for Topography window. Closes #279, Fixes #258
git-svn-id: https://svn.nmap.org/nmap@35898 e0a8ed71-7df4-0310-8962-fdc924857419
b1bf448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment