[zenmap][GUI] added topology legend button.#279
Closed
surajhande wants to merge 4 commits intonmap:masterfrom
Closed
[zenmap][GUI] added topology legend button.#279surajhande wants to merge 4 commits intonmap:masterfrom
surajhande wants to merge 4 commits intonmap:masterfrom
Conversation
|
@surajhande555 Thanks for contributing! I guess I should have been clearer with the requirements for this option. I don't think a static image will be sufficient, since we need it to look good in varying screen resolutions/sizes and to be easy to update when/if we change the images. Check back on #258 soon and I will put some notes there. |
Author
|
@dmiller-nmap I've written a LegendWindow class with all the shapes and labels drawn independently as you said. |
|
@srjhnd Thanks so much for doing this! I made a few changes to bring it in line with our code conventions, but overall this is your code and you get all the credit. Changes:
|
tremblerz
pushed a commit
to tremblerz/nmap
that referenced
this pull request
Jul 20, 2016
tremblerz
pushed a commit
to tremblerz/nmap
that referenced
this pull request
Jul 21, 2016
batrick
pushed a commit
to batrick/nmap
that referenced
this pull request
Aug 2, 2016
git-svn-id: https://svn.nmap.org/nmap@35898 e0a8ed71-7df4-0310-8962-fdc924857419
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in the issue #258 by @dmiller-nmap I added a topology "legend" button to the Toolbar. Also added an image
(legend.png) to the pixmaps folder