Fix broken reading of SSH public keys from a file#2919
Closed
nnposter wants to merge 1 commit intonmap:masterfrom
nnposter:nselibssh2-read-publickey
Closed
Fix broken reading of SSH public keys from a file#2919nnposter wants to merge 1 commit intonmap:masterfrom nnposter:nselibssh2-read-publickey
nnposter wants to merge 1 commit intonmap:masterfrom
nnposter:nselibssh2-read-publickey
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading of SSH public keys from a file via
libssh2.read_publickey()fails because the routine does not preserve balanced Lua stack across operations performed on a luaL_Buffer object. Moving the code around rectifies the issue.A minuscule optimization added by replacing
lua_pushstringwithlua_pushliteral.The PR will be committed after September 6, 2024, unless concerns are raised.