nse_libssh2.cc - callback fix #2924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callback needs to return 1 to hit the callback error check immediately after it is called in userauth.c, since nothing is being signed.
|
I believe that this is indeed the core issue but the surrounding code needs a little more work. Stay tuned. |
|
Addressed by #2925 |
|
@junedic I will credit you in the changelog once the PR gets committed. Thank you for contributing to Nmap! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callback needs to return 1 to hit the callback error check immediately after it is called in userauth.c, since the user/key combination is confirmed at this point.
Otherwise execution runs into memory corruption errors, with further authentication procedures not being implemented for publickey_canauth().