Allow crypto IVs with leading zero #2928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NSE wrapper for OpenSSL is currently testing for null IV by inspecting the first byte, as if the IV was a null-terminated string, as opposed to an arbitrary byte sequence:
nmap/nse_openssl.cc
Lines 393 to 394 in fbadb52
The impact of this misinterpretation is that both
openssl.encrypt()andopenssl.decrypt()are sporadically producing incorrect results.The PR will be committed after September 13, 2024, unless concerns are raised.