Detect if binding an rlogin socket to a given port failed and retry. #3196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnposter
force-pushed
the
lowport-rlogin-brute
branch
from
0cc64d3 to
417d0d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #2646, the
rlogin-brutescript can randomly fail due to:Regarding the second bullet, the original PR has borrowed a similar code from
rpc.lua, which unfortunately is not working as expected either, due tosocket:connect()not failing even if the invokedmksock_bind_addr()fails. (See #1939. A fix, working around this behavior, is proposed in #3194).This PR borrows the code from #3194 to address both issues.
It will be merged in after November 1 unless concerns are raised.
P.S. It begs the question whether this code should not be abstracted out and placed in one of the NSE libraries, but a cursory review of the existing scripts and libraries indicates that the code would be used only in these two locations.
P.P.S. It would be up to somebody with more intimate knowledge of Nsock to determine whether
socket:connect()should change its behavior and fail upon failingmksock_bind_addr().