-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix hostmap-crtsh script to correctly parse CT logs and return subdomains #3239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nnposter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely a good first cut, but it would benefit from a few changes. Please see the individual comments for details.
|
@nnposter Thank you for the detailed review!I've tried to incorporate all your feedback:
|
|
Hi @nnposter,
Restored the TODO block that I accidentally removed earlier Everything should now match your review requirements. Thanks again for the guidance. |
|
I have committed this PR with some minor tweaks as r39310 and credited you in CHANGELOG. Thank you for contributing to Nmap! |
|
@nnposter I can't thank you enough! This was my first time contributing to such a major project, and your detailed feedback made it an incredible learning experience. Seeing my code merged into Nmap feels amazing .Thank you very much for the opportunity and for being such a supportive reviewer. I really appreciate it! 🙏 |
This PR fixes issue #2183.
● Correctly parses JSON returned by crt.sh
● Removes false positives
● Adds strict/non-strict mode
● Ensures only valid subdomains are returned
● Adds my improvements from hostmap script