Inconsistent results of tableaux tcopy and shallow_tcopy#3287
Closed
nnposter wants to merge 2 commits intonmap:masterfrom
Closed
Inconsistent results of tableaux tcopy and shallow_tcopy#3287nnposter wants to merge 2 commits intonmap:masterfrom
nnposter wants to merge 2 commits intonmap:masterfrom
Conversation
Author
|
As a side note, construct for k, v in next, tbl do
...
endappears to iterate over large tables about 2.5x faster than local k, v = next(tbl)
while k ~= nil do
...
k, v = next(tbl, k)
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function
tableaux.tcopyproduces a full/deep copy of a given table, whiletableaux.shallow_tcopyproduces a shallow copy.A user might naturally assume that results from these two functions are identical for flat tables (tables that do not contain nested tables). However, this is not guaranteed. The reason is that the two functions iterate over the table differently:
tcopyis usingpairs, whileshallow_tcopyis usingnext. Whenpairsis used, the actual iterations are determined by a__pairsmetamethod, not necessarily relying onnext.This PR updates
tableaux.tcopyto usenextto achieve consistency withshallow_tcopy. It will be merged in after March 1st unless concerns are raised.