Repository navigation
NSE Script fix: iec61850-mms.nse and method call in iec61850mms.lua - #3307
Open
RyugaXhypeR wants to merge 2 commits into
Open
RyugaXhypeR wants to merge 2 commits into
RyugaXhypeR wants to merge 2 commits into
Conversation
|
tested against some mms compatible hw, working fine. |
RyugaXhypeR
marked this pull request as draft
April 13, 2026 11:54
RyugaXhypeR
marked this pull request as ready for review
April 18, 2026 03:10
nmap-bot
pushed a commit
that referenced
this pull request
Sep 30, 2026
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iec61850-mms.nse:
Call to
shortport.portnumber(102, "iso-tsap")was faulty. Instead of specifying the protocol in the second argument, the service was specified. Fixed it by callingshortport.port_or_serviceinstead.iec61850mms.lua:
Calls to
self.encodeSeqwere wrong.encodeSeqfromnselib/ans1.luais a method requiringselfas the first argument. Fixed it switching toself:encodeSeq.