Tolerate TLS peers that do not send close_notify - #3430
Closed
nnposter wants to merge 1 commit into
Closed
Conversation
Author
|
Committed as r39658 (115af39) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLS requires that each party sends a close_notify alert before closing the write side of the underlying transport. See RFC 8446, section 6.1 and/or RFC 5246, section 7.2.1 for details.
When using OpenSSL 3.x or higher, Nmap fails to communicate with many TLS targets that do not send this alert, which substantially limits its interoperability.
This PR rectifies the issue by tolerating this non-compliance.