fix http-config-backup bad ref - #3456
Closed
h00die wants to merge 2 commits into
Closed
Conversation
|
Fixes for the three issues have been committed with some modifications as r39712, r39713, and r39714. Thank you for contributing to Nmap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http-config-backup.nsecallsstdnse.escape_filename, however when that function was introduced in 2013 it was called actuallystdnse.filename_escape. Thus, this branch of the code never worked in the ~13 years of its life.However that was moved to
stringauxvia0500811f5(2018-10-18).This PR Fixes the function call. Once that was fixed, it exposed another bug which causes output like this:
So now we fix up that code branch to handle everything as intended.
Testing
Test script:
Function call fixed, branch still wonky.
Post
Final Fix