-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial submission of MQTT-related code to the Nmap project. #352
Conversation
Fun! I only just read about MQTT yesterday when looking for more TLS-secured protocols. I'll take a look at your submission. |
Thanks! I'm hoping to add some more protocols in the coming weeks, all for a project in an Internet of Things course. |
Some feedback:
Thanks so much for using |
I'll make those changes today. Thanks for the quick turnaround on reviewing! |
…permits the use of tryssl().
I have made the recommended changes, including the stylistic ones. |
Did some minor cleanup, and added a bunch of tests for the very sensitive functions that are used for generating and parsing values. |
It's been a while, wondering if there's anything that's needed from me that would help move this along? |
I am submitting a new port definition, service probe, discovery script, and protocol library for MQTT, an Internet of Things publish-subscribe protocol. MQTT is standardized and has many implementations and public test servers.
The code in this branch has one deficiency that I suspect the reviewer(s) can help fix: it does not properly connect over TLS for either the service probe nor the discovery script.
The following command lines can be used to test multiple public test servers using multiple MQTT broker implementations both with and without user authentication.
Without user authentication and without TLS (working):
nmap -p 1883 --script mqtt-subscribe test.mosquitto.org
nmap -p 1883 --script mqtt-subscribe broker.hivemq.com
nmap -p 1883 --script mqtt-subscribe broker.mqttdashboard.com
With user authentication and without TLS (working):
nmap -PN -sV --allports -p 11638 --script mqtt-subscribe --script-args=username=nmap,password=hunter2 m10.cloudmqtt.com
Without user authentication and with TLS (not working):
nmap -p 8883 --script mqtt-subscribe test.mosquitto.org
If you have any questions or guidance, I will do my best to respond promptly.