Detect DROWN with NSE script sslv2-drown #365

Closed
wants to merge 12 commits into
from

Conversation

Projects
None yet
2 participants

bbc2 commented Apr 14, 2016

This adds the detection of severe SSLv2 vulnerabilities in OpenSSL (CVE-2015-3197, CVE-2016-0703 and CVE-2016-0800, also known as DROWN). The three CVEs are related and the result of the test should give an idea of how vulnerable the tested server is. I've tested the script with real servers from https://test.drownattack.com/ and relevant versions of OpenSSL s_server). Because they can be intrusive, those tests are only performed if the sslv2.extended-test script-arg is given. The default behavior of the script is mostly the same as before.

To deal with more than SSLv2 hello packets, I've had to refine the decoding and encoding of packets and I followed the draft spec for that. For instance, this should make record length computing a lot clearer. The script should also be easier to extend in the future.

I've mentioned this work on the mailing-list some time ago: http://seclists.org/nmap-dev/2016/q1/259 and as said there, I'd be happy to get feedback on this new version.

Thanks for this good work! I like the idea of specific checks for the 3 SSLv2-related vulnerabilities, but I have 2 concerns with including them in the sslv2 script directly:

  1. Users are much less likely to use a feature of a script that requires using a script-arg to activate than if they can just add another term or wildcard to their --script option.
  2. Removing the "safe" category will prevent many users who currently restrict themselves to "safe" scripts from detecting SSLv2 at all.

I would like to see how this PR would look with the following changes:

  • Only simple enhancements to sslv2.nse if you have discovered problems with how it currently works.
  • A new script, sslv2-drown, for checking the forced-cipher and clear-key vulnerabilities. The regular sslv2 script could store discovered ciphers in the host registry, with sslv2-drown using dependencies to indicate that sslv2 should run first if it is selected, in order to avoid repeating the basic handshake if possible.
  • Use the vulns NSE library for reporting vulnerability info.

@bbc2 Be sure to let us know when you think this is ready for review again.

bbc2 commented May 11, 2016

OK! It's not ready yet.

bbc2 added some commits Jan 21, 2016

@bbc2 bbc2 sslv2: Return empty table instead of "none" cipher
This fixes the XML output but leaves the human-readable output unchanged.
5aca781
@bbc2 bbc2 sslv2: Read exact numbers of bytes from a socket
This is important if more than one SSL record is to be read, which will be the
case later.
35a46ae
@bbc2 bbc2 sslv2: Wrap record parsing in a function
A draft of SSL 2 is available at the following address:
https://tools.ietf.org/html/draft-hickman-netscape-ssl-00
39f3eed
@bbc2 bbc2 sslv2: Extract testing into a separate function b02daf7
@bbc2 bbc2 sslv2-drown: Detect OpenSSL disabled ciphers bug
This improves sslv2 with new data structures to make it easier to extend.

sslv2-drown is a new script copied from sslv2 and which is aimed at finding
DROWN-related vulnerabilities. See CVE-2015-3197 and [1] for more information
about the one detected with this commit.

[1]: https://www.openssl.org/news/secadv/20160128.txt
d567fc4
@bbc2 bbc2 sslv2: Add support for the NULL_WITH_MD5 suite 51fcd42
@bbc2 bbc2 sslv2-drown: Detect extra clear bug: CVE-2016-0703 d36ddd8
@bbc2 bbc2 sslv2-drown: Detect DROWN (CVE-2016-0800) 049ccd6
@bbc2 @bbc2 bbc2 sslv2-drown: Use the vulns NSE library efec401
@bbc2 bbc2 sslv2-drown: Use host registry from sslv2
If not available, do the sslv2 test anyway.  It's required to check for
CVE-2015-3197.
798625a
@bbc2 bbc2 sslv2, sslv2-drown: Update documentation 7436bb7
@bbc2 bbc2 sslv2-drown: Set categories to intrusive and vuln 2db5907

bbc2 commented May 26, 2016 edited

@dmiller-nmap It's ready for review. Thank you for your help!

I've hopefully addressed all your concerns. I don't know what is the best practice for NSE libraries but we could win a lot on code deduplication if the two scripts shared common SSLv2 structures and functions.

bbc2 changed the title from NSE sslv2 upgrade with optional CVE tests to Detect DROWN with NSE script sslv2-drown May 27, 2016

Working on integrating this. Partially applied changes to sslv2.nse, along with some of my own improvements. Expect to have your DROWN script and possibly a sslv2 library committed in the next few days. Thanks so much for this great work!

@bbc2 You list these ciphers as "weak enough to enable" DROWN:

-- Those ciphers are weak enough to enable a "General DROWN" attack.
local GENERAL_DROWN_CIPHERS = {
  [SSL_CK.RC2_128_CBC_EXPORT40_WITH_MD5] = true,
  [SSL_CK.RC4_128_EXPORT40_WITH_MD5] = true,
  [SSL_CK.DES_64_CBC_WITH_MD5] = true,
}

Why these and not SSL2_RC4_64_WITH_MD5? It also has an encrypted-key length of 8 (64 bits) like SSL2_DES_64_CBC_WITH_MD5.

On the other hand, the DROWN paper only mentions EXPORT ciphers (40 bits) as being vulnerable, so should SSL2_DES_64_CBC_WITH_MD5 be removed from the list?

@dmiller-nmap dmiller-nmap commented on the diff Jul 7, 2016

scripts/sslv2-drown.nse
+
+ -- CVE-2015-3197
+ local forced_ciphers = {}
+ for _, cipher in pairs(SSL_CK) do
+ if try_force_cipher(host, port, cipher) then
+ table.insert(forced_ciphers, cipher)
+ end
+ end
+ output.forced_ciphers = format_ciphers(forced_ciphers)
+ if not values_in(forced_ciphers, offered_ciphers) then
+ cve_2015_3197.state = vulns.STATE.VULN
+ end
+
+ -- CVE-2016-0703
+ for _, cipher in pairs(forced_ciphers) do
+ local result = has_extra_clear_bug(host, port, cipher)
@dmiller-nmap

dmiller-nmap Jul 7, 2016

@bbc2 Do we really need to try this for every discovered cipher? If the bug is there, it should show up no matter what the cipher we choose. I'll test it myself if you don't have further insight.

@bbc2

bbc2 Jul 7, 2016

That's right, if the bug is there, it will stop at the first cipher suite with which it detected it (see the break below). However, it will try all cipher suites until it detects it, which might be unnecessary. I tried to remember why it does it like that but can't. It should be enough to only test the first cipher we get and determine whether the bug is there or not.

bbc2 commented Jul 7, 2016

I took the list of weak enough ciphers from an early version of the DROWN paper which listed them explicitly. In the published version it's less obvious but please see the last paragraph of section 4.1 (The SSLv2 export padding oracle):

If the server does not support 40-bit export ciphers, the attack can also be mounted in feasible computation time by choosing DES as the symmetric cipher.

Even though DES requires 64-bit keys, it only uses 56 bits from them, making it a lot weaker against bruteforce than other ciphers with 64-bit keys.

nmap-bot closed this in b47c55d Jul 7, 2016

bbc2 commented Jul 7, 2016

Thanks for the review and the integration, it's awesome!

@tremblerz tremblerz added a commit to tremblerz/nmap that referenced this pull request Jul 20, 2016

@bonsaiviking @tremblerz bonsaiviking + tremblerz Add sslv2-drown. Closes #365 e7cc075

@tremblerz tremblerz added a commit to tremblerz/nmap that referenced this pull request Jul 21, 2016

@bonsaiviking @tremblerz bonsaiviking + tremblerz Add sslv2-drown. Closes #365 3d563b0

@sergeykhegay sergeykhegay added a commit to sergeykhegay/nmap that referenced this pull request Jul 27, 2016

@bonsaiviking @sergeykhegay bonsaiviking + sergeykhegay Add sslv2-drown. Closes #365 4f07a91

@batrick batrick pushed a commit to batrick/nmap that referenced this pull request Aug 2, 2016

@bonsaiviking bonsaiviking Improve parsing and request building in sslv2. Part of #365
git-svn-id: https://svn.nmap.org/nmap@35939 e0a8ed71-7df4-0310-8962-fdc924857419
3e86b20

@batrick batrick pushed a commit to batrick/nmap that referenced this pull request Aug 2, 2016

@bonsaiviking bonsaiviking Add sslv2-drown. Closes #365
git-svn-id: https://svn.nmap.org/nmap@35965 e0a8ed71-7df4-0310-8962-fdc924857419
2d3a926

bbc2 deleted the bbc2:cryptosense-sslv2 branch Sep 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment