Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing from Macports to Jhbuild #420

Closed
wants to merge 5 commits into from

Conversation

@ghost
Copy link

commented Jun 15, 2016

I had to add libsqlite3 and libz in static linking to make it work.

Dumont added 3 commits Jun 15, 2016
nmap-update now uses static libraries linking for libapr, libsvn,
libserf, libz and libsqlite3
Dumont Vincent added 2 commits Jun 21, 2016
Dumont Vincent
Dumont Vincent
I removed zlib and sqlite because gtk already had them installed with Jhbuild. Instead, we now use the default versions chipped with it.
I also changed the gtk path by PREFIX.
@dmiller-nmap

This comment has been minimized.

Copy link

commented Jul 12, 2016

This works great, now! Do also update the BUILDING.md file to include the required jhbuild build meta-gtk-osx-python step. I also had to delete my .jhbuildrc-custom file and allow the gtk-osx-build-setup.sh script to recreate it because it was incompatible with a recent update, but I don't know that that belongs in our documentation.

Commit away!

@dmiller-nmap

This comment has been minimized.

Copy link

commented Jul 13, 2016

@W0naN0w Found a slight problem: the MAC_FLAGS variable is not part of the configure script, so @MAC_FLAGS@ will not be substituted during configure. For OS X, this isn't a problem because we pass MAC_FLAGS on the command line, but for other platforms, it results in the literal string @MAC_FLAGS@ being passed to the linker. The line should instead be an empty assignment:

MAC_FLAGS=

This ensures it will be blank unless it is passed via the make command line.

@ghost ghost referenced this pull request Jul 15, 2016
@ghost

This comment has been minimized.

Copy link
Author

commented Jul 15, 2016

@dmiller-nmap, I just opened a new PR, #457 to update this one. I also updated BUNDLING.md directly on the svn trunk with the following changes:

  • Add .jhbuildrc-custom to the rm command at the beginning of the file
  • Add the jhbuild build meta-gtk-osx-python step

Thank you again for all your work!

@ghost ghost closed this Jul 15, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.