-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DTLS and ALPN client support. #446
Conversation
@denandz Thanks for this contribution! It looks like a fun and exciting addition to our program. Before we can review it, please ensure that it passes our build test. Specifically, you should guard sections of code that depend on OpenSSL with |
@dmiller-nmap Also, in the travis-ci non-ssl builds are being built with openssl. The './configure $SSL_FLAG' doesn't seem to work as expected. On my system: $ export SSL_FLAG="--without-ssl" Similar is reflected in the travis-ci build logs. (EG: https://travis-ci.org/nmap/nmap/jobs/142393838) |
@denandz Thanks for pointing that out about the travis builds! I just pushed a change to correctly configure without OpenSSL. Hope to be able to review this pull soon. |
@dmiller-nmap any update on the pull ? |
McFly? |
Thanks again for this! Turns out we had a good deal of work to do to make
it fit: found a bug in ciphersuite defaults, did a bit of refactoring, had
to update the patch due to intermediate code changes, fixed up some tests
that were failing on fast hardware, added documentation, added compile-time
feature detection instead of version number checks (sorry I steered you
wrong on that), etc.
Commit incoming. If you want a different name credited in the changelog,
let me know.
|
Thanks @dmiller-nmap! You can use Denis Andzakovic as the credit name in the change log. Thanks for merging these features ^_^ |
This change adds support Datagram Transport Layer Security (DTLS) when creating UDP connections with ncat. Application-Layer Protocol Negotiation (ALPN) support has also been added, allowing the user to specify an ALPN string when connecting the SSL services. For example, connecting to an HTTP2 compatible web server and supplying the 'h2' ALPN string.