This actually closes #394, since this PR is a fresh update coded on the actual source code along with some little changes in the createdmg.sh script.
Add background DMG image / design
Modify Makefile to call the createdmg.sh script
Add a script to produce the designed DMG without writing rights
I just put 2 second to wait before running the Applescript, just to be sure even old machine can run this script.
@w0nan0w Is there any way this could be extended to check the values that we just set? Can we remount it and query the background image or the icon locations? This way we could get a solid indication that everything worked so that we don't have a regression.
A few things needed to be changed in order for this to work:
svn propset svn:executable on createdmg.sh
After these changes, everything works great. My only remaining suggestion would be to see if we can put in a loop to continue sleeping until the disk is mounted: we could check for existence of /Volumes/nmap-$VERSION/README or similar to know when to stop. And only sleep for 10 seconds at most or something.
Hello @dmiller-nmap, good news is yes (I wasn't sure), we can do a script to verify everything went ok! I am currently on it :) I changed the size as you said, I forgot this property and it now works well. I think that I changed the file to README.md on the main trunk but I'll have to double-check. Finally, thank you for all the information, I am working on applying all this checks.
Talk to you soon!
Add test script
This script is intended to check the DMG created by createdmg.sh. It checks for:
* Icons position
Enhance script to ensure there will be no problem
Add comment for setting a .mpkg (installer) background image
Add proper checks with variables and waiters
Merge branch 'mac/dmg_img' of https://github.com/W0naN0w/nmap into ma…
Update Makefile from the actual source code
This PR has been merged with the SVN trunk, along with a few modifications (revision 36075).