Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Final designed DMG #454

Closed
wants to merge 12 commits into
from

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Jul 12, 2016

This actually closes #394, since this PR is a fresh update coded on the actual source code along with some little changes in the createdmg.sh script.

@ghost ghost referenced this pull request Jul 12, 2016

Closed

Final designed DMG image #394

@ghost

ghost commented Jul 12, 2016

I just put 2 second to wait before running the Applescript, just to be sure even old machine can run this script.

@w0nan0w Is there any way this could be extended to check the values that we just set? Can we remount it and query the background image or the icon locations? This way we could get a solid indication that everything worked so that we don't have a regression.

A few things needed to be changed in order for this to work:

  • The size is too small, and results in errors about not being able to access nmap-$VERSION.mpkg. Increasing it to 40000K helped. This is probably because of finally getting static linking to work for nmap-update.
  • This mentions README.md, and the branch I am on had README instead. I'm not sure which one the trunk currently has, but we should be sure to make them match.
  • createdmg.sh needs to be executable. You should be able to just chmod +x before doing svn add, but if you do not, then you can do svn propset svn:executable on createdmg.sh

After these changes, everything works great. My only remaining suggestion would be to see if we can put in a loop to continue sleeping until the disk is mounted: we could check for existence of /Volumes/nmap-$VERSION/README or similar to know when to stop. And only sleep for 10 seconds at most or something.

@ghost

ghost commented Jul 13, 2016

Hello @dmiller-nmap, good news is yes (I wasn't sure), we can do a script to verify everything went ok! I am currently on it :) I changed the size as you said, I forgot this property and it now works well. I think that I changed the file to README.md on the main trunk but I'll have to double-check. Finally, thank you for all the information, I am working on applying all this checks.

Talk to you soon!

@ghost

ghost commented Aug 2, 2016

This PR has been merged with the SVN trunk, along with a few modifications (revision 36075).

@ghost ghost closed this Aug 2, 2016

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment